You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the chief of the wind tribe, I don't mind if you have some other way you want to do this. I avoided adding another option because there's already a bunch of stuff going on in batch.
Basically I'm trying to solve the situation where:
Two consumers (for arguments sake) are listening for SQS events for email tracking,
One email (for arguments sake) is sent,
Each consumer receives the message 5 times, but neither reaches the options.n size of 10 and, thus, don't release the batch that tells AWS to delete the message,
The SQS queue, having sent the message 10 times, considers it dead and puts it on the DLQ.
By allowing partial batches to be emitted on a timeout, those messages can be properly cleaned up. To give you an idea of how often this happens, there's 1300 messages in the DLQ right now and I emptied it at the start of the week.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Just to confirm, does the timeout option not work here?
It depends on what you mean by work. If you have n and timeout in options then a timeout will only send a batch if there's n items in it, which leads to the scenario above (where a partial batch can be held for one or more timeouts).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the chief of the wind tribe, I don't mind if you have some other way you want to do this. I avoided adding another option because there's already a bunch of stuff going on in batch.
Basically I'm trying to solve the situation where:
options.nsize of 10 and, thus, don't release the batch that tells AWS to delete the message,By allowing partial batches to be emitted on a timeout, those messages can be properly cleaned up. To give you an idea of how often this happens, there's 1300 messages in the DLQ right now and I emptied it at the start of the week.